|
9321
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or
join
clauses before calling
cursor()
.
To give you the exact line-by-line review you are looking for, would you be able to share the actual code snippet for the
LoadDocumentsAction
class?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9321
|
|
9320
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9320
|
|
9319
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or
join
clauses before calling
cursor()
.
To give you the exact line-by-line review you are looking for, would you be able to share the actual code snippet for the
LoadDocumentsAction
class?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9319
|
|
9318
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or
join
clauses before calling
cursor()
.
To give you the exact line-by-line review you are looking for, would you be able to share the actual code snippet for the
LoadDocumentsAction
class?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9318
|
|
9317
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9317
|
|
9316
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents....
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9316
|
|
9315
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or
join
clauses before calling
cursor()
.
To give you the exact line-by-line review you are looking for, would you be able to share the actual code snippet for the
LoadDocumentsAction
class?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9315
|
|
9314
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or
join
clauses before calling
cursor()
.
To give you the exact line-by-line review you are looking for, would you be able to share the actual code snippet for the
LoadDocumentsAction
class?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9314
|
|
9313
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Listen
Show more options
Show thinking
Gemini said
Gemini said
I completely understand wanting a deep dive into the production code. However, I need to gently point out that the snippet you provided earlier
only contains test code
—specifically the test class for
LoadDocumentsAction
. There are no non-test files included in that selection.
That being said, a good test suite acts as documentation for the underlying implementation. By looking at how your tests interact with
LoadDocumentsAction
, I can actually deduce how the production code is structured and flag several
potential architectural bottlenecks
in your implementation.
Here is what the tests reveal about the unseen production code, and what you should look out for:
1. Memory Exhaustion Defeating the Cursor
1. Memory Exhaustion Defeating the Cursor
Implied Code:
The tests mock the
EntityQueryBuilder
to return a
cursor()
(Line 254), which is great for streaming large database reads without exhausting memory. However, Lines 51-54 (
$result->getDocumentsToUpdate()->toArray()
) show that
LoadDocumentsAction
returns a result object containing a collection of all processed documents.
The Bottleneck:
If
loadDocuments()
is iterating over a database cursor but then pushing every newly created
Document
object into an array in memory to return at the end,
it completely defeats the purpose of the cursor
. If you try to reindex 500,000 records, the app will likely throw a Fatal Out Of Memory (OOM) error before it ever finishes building that result object.
Recommendation:
Ensure the production code is processing and pushing documents in chunks/batches, or that
loadDocuments
yields a Generator rather than accumulating all results in memory.
2. Sentry API Flooding & Latency
2. Sentry API Flooding & Latency
Implied Code:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Lines 134-137), the test verifies that if hydration fails for a specific entity, a
SyncActivityException
is caught and immediately dispatched to Sentry via
captureException()
, allowing the loop to continue.
The Bottleneck:
Catching and logging exceptions inside a tight loop is extremely dangerous for bulk operations. If a schema change or bad data causes 50,000 entities to fail hydration, your worker will make 50,000 synchronous API calls to Sentry. This will severely throttle your worker's processing speed and likely cause Sentry to rate-limit or block your project.
Recommendation:
Implement a failure threshold (e.g., abort the job if more than 100 errors occur) or aggregate the exceptions and send a single summary report to Sentry at the end of the batch.
3. N+1 Query Risks During Hydration
3. N+1 Query Risks During Hydration
Implied Code:
Line 195 (
getIndexableAttributes()
) simulates the entity transforming its data into a format ready for the search index.
The Bottleneck:
While the test mocks this with a static array, in production, gathering indexable attributes usually requires accessing relationships (e.g., an Opportunity's related Contacts or Account). If the
EntityQueryBuilder
does not eagerly load (eager fetch) these relationships before yielding the cursor, every single entity will trigger subsequent database queries inside the
loadDocuments
loop, resulting in a massive N+1 performance crawl.
Recommendation:
Verify that the
EntityQueryBuilder
in the production code explicitly includes the necessary
with()
or...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9313
|
|
9312
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-940 github.com/jiminny/app/pull/12059/changes#diff-940a2785a5caa141fc5cf73414adfa0cf94dc319d74d7215178ccf20020de76b...
|
9312
|
|
9311
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Gemini is typing
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out....
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9311
|
|
9310
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
You said
Ok, do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9310
|
|
9309
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Ok do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Ok do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Open upload file menu
Tools
Open mode picker
Pro
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9309
|
|
9308
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Ok do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Ok do the same but focus mainly on non test files. If you are referring to some code provide file name and line
Open upload file menu
Tools
Open mode picker
Pro
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9308
|
|
9307
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9307
|
|
9306
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9306
|
|
9305
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9305
|
|
9304
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Ok do the same but focus mainly on non test files. If you are reffer
Ok do the same but focus mainly on non test files. If you are reffer
Open upload file menu
Tools
Open mode picker
Pro
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9304
|
|
9303
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9303
|
|
9302
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9302
|
|
9301
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9301
|
|
9300
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9300
|
|
9299
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9299
|
|
9298
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
Jy 20820 es reindex stream model hydration
Jy 20820 es reindex stream model hydration
#
12059
All commits
All commits
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
0 of 12 files viewed
Awaiting approval
Awaiting approval
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Component
ElasticSearch/Contract
Searchable.php
Searchable.php
ES
Processor...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9298
|
|
9297
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
Jy 20820 es reindex stream model hydration
Jy 20820 es reindex stream model hydration
#
12059...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9297
|
|
9296
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9296
|
|
9295
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9295
|
|
9294
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9294
|
|
9293
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9293
|
|
9292
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9292
|
|
9291
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9291
|
|
9290
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes#diff-440 github.com/jiminny/app/pull/12059/changes#diff-440beab30ba7b8b55f8e107df64f066144059c5088901522087f42a83f2d2657...
|
9290
|
|
9289
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9289
|
|
9288
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer, I’ve taken a close look at the provided test suite. Overall, the tests are well-structured: using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup, and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However, looking carefully at the implementation details, there are a few potential issues, test-state leaks, and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139), you use
Sentry::swap($sentryMock);
. If there is no
tearDown()
method in this test class to reset or clear the Sentry facade, this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
. If they throw an exception, it will be caught by the "do nothing" mock, leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade, or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file, outside the test class.
The Risk:
If PHPUnit loads this file multiple times, or if another test in the suite also defines a
class SentryMock
in the same namespace, the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move
SentryMock
into a dedicated
tests/Mocks
directory/namespace, or use PHPUnit’s built-in mocking dynamically (e.g.,
$sentryMock = $this->createMock(HubInterface::class);
). If you really want a concrete mock, use an anonymous class right inside the test.
Logical Discrepancies & Bottlenecks
Logical Discrepancies & Bottlenecks
Exception Wrapping Assumption
The Issue:
In
createEntityMockWithException
(Line 237), the mock throws a native
\RuntimeException
. However, in the test (Line 137), Sentry is asserted to capture a
SyncActivityException
.
The Risk:
This implies that
LoadDocumentsAction
is catching the
\RuntimeException
and wrapping it in a
SyncActivityException
. While this is fine, if the underlying implementation actually just catches
Throwable
and logs it as-is, this test will fail.
Recommendation:
Ensure the actual action class explicitly handles this wrapping. To make the test clearer, you might want the mock to throw the exact exception type you expect the system to generate or handle, unless testing the wrapping logic is the explicit goal.
Memory Bottlenecks in Production (Implied by Assertions)
The Issue:
The tests heavily use
->toArray()
on the returned documents (e.g., Lines 54, 81, 109).
The Risk:
Since
EntityQueryBuilder->cursor()
is being used to prevent loading thousands of records into memory, if the underlying
LoadDocumentsAction
stores all processed
Document
objects in memory just to return them as a giant array or collection, it defeats the purpose of using a cursor.
Recommendation:
Verify that the actual implementation of
loadDocuments
yields a Generator or processes batches. If it returns a massive Collection of all documents, large reindex jobs will run out of memory.
Code Style & Minor Improvements
Code Style & Minor Improvements
Missing Return Types
The
captureException
method in
SentryMock
(Line 262) is missing a
: void
return type. Since this is modern PHP (indicated by constructor property promotion), strict types should be enforced everywhere.
Magic Numbers & Strings
While acceptable in tests, utilizing hardcoded strings like
'test_index'
across multiple anonymous classes is slightly repetitive. If the index changes, you have multiple places to update. Consider passing the index name as a parameter to the mock builder.
Overall, it's a very solid PR, but fixing the Sentry facade state leakage is critical to keeping the test suite reliable.
Would you like me to draft a refactored version of this test class that addresses the Sentry state leakage and class redeclaration issues?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9288
|
|
9287
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer,
I’ve taken a close look at the provided test suite.
Overall,
the tests are well-structured:
using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup,
and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However,
looking carefully at the implementation details,
there are a few potential issues,
test-state leaks,
and design quirks that we should address before merging.
Here is my detailed review of the provided changes:...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9287
|
|
9286
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer,
I’ve taken a close look at the provided test suite.
Overall,
the tests are well-structured:
using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup,
and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However,
looking carefully at the implementation details,
there are a few potential issues,
test-state leaks,
and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139),
you use
Sentry::swap($sentryMock);
.
If there is no
tearDown()
method in this test class to reset or clear the Sentry facade,
this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
.
If they throw an exception,
it will be caught by the "do nothing" mock,
leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade,
or explicitly reset it at the end of the test.
Class Redeclaration Risk (
SentryMock
)
The Issue:
You defined
class SentryMock
(Lines 260-266) at the bottom of the file,
outside the test class.
The Risk:
If PHPUnit loads this file multiple times,
or if another test in the suite also defines a
class SentryMock
in the same namespace,
the test suite will crash with a
Cannot declare class SentryMock, because the name is already in use
fatal error.
Recommendation:
Move...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9286
|
|
9285
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer,
I’ve taken a close look at the provided test suite.
Overall,
the tests are well-structured:
using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup,
and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However,
looking carefully at the implementation details,
there are a few potential issues,
test-state leaks,
and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139),
you use
Sentry::swap($sentryMock);
.
If there is no
tearDown()
method in this test class to reset or clear the Sentry facade,
this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
.
If they throw an exception,
it will be caught by the "do nothing" mock,
leading to false positives in your test suite.
Recommendation:
Add a...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9285
|
|
9284
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand
Show more options
Show thinking
Gemini said
Gemini said
As a seasoned code reviewer,
I’ve taken a close look at the provided test suite.
Overall,
the tests are well-structured:
using anonymous classes for mocking
Searchable
entities is a clever way to avoid heavy mock setup,
and using an
ArrayIterator
to simulate a database cursor is a solid approach for testing stream hydration.
However,
looking carefully at the implementation details,
there are a few potential issues,
test-state leaks,
and design quirks that we should address before merging.
Here is my detailed review of the provided changes:
Critical Issues & Test State Leaks
Critical Issues & Test State Leaks
Global State Mutation Without Cleanup (
Sentry::swap
)
The Issue:
In
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
(Line 139),
you use
Sentry::swap($sentryMock);
.
If there is no
tearDown()
method in this test class to reset or clear the Sentry facade,
this mock will persist into other tests that run after it.
The Risk:
Subsequent tests that rely on Sentry (or expect it not to be mocked) will silently use this
SentryMock
.
If they throw an exception,
it will be caught by the "do nothing" mock,
leading to false positives in your test suite.
Recommendation:
Add a
protected function tearDown(): void
method to this test class to reset the Sentry facade,
or explicitly reset it at the end of the test.
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9284
|
|
9283
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
You said
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes. Then evaluate them file by file and look for potential issues. Be detailed and careful.
Expand...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9283
|
|
9282
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Jy 20807 check various issues with stages by nikolaybiaivanov · Pull Request #12041 · jiminny/app
Jy 20807 check various issues with stages by nikolaybiaivanov · Pull Request #12041 · jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20818 move ask jiminny reports to its own datadog metric by LakyLak · Pull Request #12056 · jiminny/app
JY-20818 move ask jiminny reports to its own datadog metric by LakyLak · Pull Request #12056 · jiminny/app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
JY-20773 fix user pilot tracking ofr automated report generated by LakyLak · Pull Request #12024 · jiminny/app
JY-20773 fix user pilot tracking ofr automated report generated by LakyLak · Pull Request #12024 · jiminny/app
Problem loading page
Problem loading page
Search the CRM - HubSpot docs
Search the CRM - HubSpot docs
Jiminny
Jiminny
New Tab
New Tab
New Tab
New Tab
AI Features | Datadog
AI Features | Datadog
Jy 20493 smart instant nudge pre filtering by nikolaybiaivanov · Pull Request #12053 · jiminny/app
Jy 20493 smart instant nudge pre filtering by nikolaybiaivanov · Pull Request #12053 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app
Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9282
|
|
9281
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Jy 20807 check various issues with stages by nikolaybiaivanov · Pull Request #12041 · jiminny/app
Jy 20807 check various issues with stages by nikolaybiaivanov · Pull Request #12041 · jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20818 move ask jiminny reports to its own datadog metric by LakyLak · Pull Request #12056 · jiminny/app
JY-20818 move ask jiminny reports to its own datadog metric by LakyLak · Pull Request #12056 · jiminny/app...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9281
|
|
9280
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Redo
Share & export
Copy
Show more options
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes
find potential issues and bottlenecks. Act as seasoned code reviewer. First get familiar with the changes
Open upload file menu
Tools
Open mode picker
Pro
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9280
|
|
9279
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9279
|
|
9278
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9278
|
|
9277
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 12 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9277
|
|
9276
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9276
|
|
9275
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Listen
Show more options
Show thinking
Gemini said
Gemini said
Core Objective
Core Objective
This selection introduces a comprehensive suite of PHPUnit tests for the
LoadDocumentsAction
class. The goal is to verify the logic of the
loadDocuments
method, ensuring it correctly transforms streamed database entities into search-indexable documents, accurately segregates them into "update" and "delete" queues, and handles individual hydration failures without crashing the entire batch process.
Key Behaviors Verified
Key Behaviors Verified
Standard Hydration:
Confirms that active entities (
isDeleted = false
) are properly parsed into
Document
objects containing the correct IDs and indexable attributes.
Deletion Handling:
Ensures entities flagged as deleted (
isDeleted = true
) are added to the deletion queue and excluded from the update queue.
Mixed Batch Processing:
Validates the system's ability to process a single stream containing both active and deleted entities, successfully splitting them into their respective queues.
Empty Result Sets:
Verifies that providing an empty list of entity IDs resolves gracefully, returning zero documents to update or delete without error.
Fault Tolerance:
Ensures that if a specific entity throws an exception during attribute generation, the error is logged to Sentry (as a
SyncActivityException
), and the system successfully continues processing the remaining valid entities.
Structural & Mocking Changes
Structural & Mocking Changes
Anonymous Class Mocks:
Introduces helper methods (
createEntityMock
,
createEntityMockWithException
) that utilize anonymous classes implementing the
Searchable
interface to simulate different entity states cleanly.
Cursor Simulation:
Mocks the
EntityQueryBuilder
to return an
ArrayIterator
via a
cursor()
method, mimicking the streaming behavior of a database query.
Sentry Facade Swapping:
Implements a
SentryMock
to intercept and assert exception handling logic without triggering actual Sentry events during test execution.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it....
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9275
|
|
9274
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Gemini is typing
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 12 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Component
ElasticSearch/Contract
Searchable.php
Searchable.php
ES
Processor
Actions
LoadDocumentsAction.php
Traits
SkipActivityTrait.php
EntityQueryBuilder.php
EntityQueryBuilder.php
Repositories
EsResetActivityRepository.php
EsResetActivityRepository.php
ElasticSearchDocumentPartialUpdater.php
ElasticSearchDocumentPartialUpdater.php
Console/Commands/Elasticsearch
AsyncUpdateEsActivities.php
AsyncUpdateEsActivities.php
AsyncUpdateEsEntities.php
AsyncUpdateEsEntities.php
Models/ElasticSearch
OpportunityElasticSearchTrait.php
OpportunityElasticSearchTrait.php
tests/Unit/Component/ES/Processor
Actions
LoadDocumentsActionTest.php
LoadDocumentsActionTest.php
Traits
SkipActivityTraitTest.php
SkipActivityTraitTest.php
EntityQueryBuilderTest.php
EntityQueryBuilderTest.php
Collapse file
app/Component/ElasticSearch/Contract/Searchable.php
app/Component/ElasticSearch/Contract/Searchable.php
app/Component/ElasticSearch/Contract/Searchable.php
Copy file name to clipboard
Expand all lines: app/Component/ElasticSearch/Contract/Searchable.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -18,4 +18,8 @@ public function getIndex(): string;
18
public
function
getSearchKey
():
int
;
18
public
function
getSearchKey
():
int
;
19
19
20
public
function
getIndexableAttributes
():
array
;
20
public
function
getIndexableAttributes
():
array
;
21
+
22
+
public
function
isDeleted
():
bool
;
23
+
24
+
public
function
setRelations
(
array
$
relations
);
21
}
25
}
Original file line number
@@ -18,4 +18,8 @@ public function getIndex(): string;
18
19
20
21
Original file line
@@ -18,4 +18,8 @@ public function getIndex(): string;
public
function
getSearchKey
():
int
;
public
function
getIndexableAttributes
():
array...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9274
|
|
9273
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection. Instructions: Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language. Highlight key changes: Break down the structural or logical changes made in the code. Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs. Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
You said
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Expand
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Pro
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Gemini is typing
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 12 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Component
ElasticSearch/Contract
Searchable.php
Searchable.php
ES
Processor
Actions
LoadDocumentsAction.php
Traits
SkipActivityTrait.php
EntityQueryBuilder.php
EntityQueryBuilder.php
Repositories
EsResetActivityRepository.php
EsResetActivityRepository.php
ElasticSearchDocumentPartialUpdater.php
ElasticSearchDocumentPartialUpdater.php
Console/Commands/Elasticsearch
AsyncUpdateEsActivities.php
AsyncUpdateEsActivities.php
AsyncUpdateEsEntities.php
AsyncUpdateEsEntities.php
Models/ElasticSearch
OpportunityElasticSearchTrait.php
OpportunityElasticSearchTrait.php
tests/Unit/Component/ES/Processor
Actions
LoadDocumentsActionTest.php
LoadDocumentsActionTest.php
Traits
SkipActivityTraitTest.php
SkipActivityTraitTest.php
EntityQueryBuilderTest.php
EntityQueryBuilderTest.php
Collapse file
app/Component/ElasticSearch/Contract/Searchable.php
app/Component/ElasticSearch/Contract/Searchable.php
app/Component/ElasticSearch/Contract/Searchable.php
Copy file name to clipboard
Expand all lines: app/Component/ElasticSearch/Contract/Searchable.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -18,4 +18,8 @@ public function getIndex(): string;
18
public
function
getSearchKey
():
int
;
18
public
function
getSearchKey
():
int
;
19
19
20
public
function
getIndexableAttributes
():
array
;
20
public...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9273
|
|
9272
|
Platform Sprint 3 Q2 - Platform Team - Scrum Board Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 3 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20820 es reindex stream model hydration by Vasi</tabTitle>” with “<selection>@@ -0,0 +1,266 @@1+queryBuilder = $this->createMock(EntityQueryBuilder::class);29+$this->action = new LoadDocumentsAction($this->queryBuilder);30+ }31+32+public function testLoadDocumentsWithEntitiesToUpdate(): void33+ {34+$entityIds = [1, 2, 3];35+$updateTarget = UpdateTarget::ACTIVITY;36+37+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);38+$entity2 = $this->createEntityMock(2, false, ['field2' => 'value2']);39+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);40+41+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3]);42+43+$this->queryBuilder44+ ->expects($this->once())45+ ->method('getEntityQuery')46+ ->with($updateTarget, $entityIds)47+ ->willReturn($queryBuilder);48+49+$result = $this->action->loadDocuments($updateTarget, $entityIds);50+51+$this->assertEquals(3, $result->getDocumentsToUpdate()->count());52+$this->assertEquals(0, $result->getDocumentsToDelete()->count());53+54+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();55+$this->assertInstanceOf(Document::class, $documentsToUpdate[0]);56+$this->assertEquals('1', $documentsToUpdate[0]->getId());57+$this->assertEquals(['field1' => 'value1'], $documentsToUpdate[0]->getData());58+ }59+60+public function testLoadDocumentsWithEntitiesToDelete(): void61+ {62+$entityIds = [1, 2];63+$updateTarget = UpdateTarget::OPPORTUNITY;64+65+$entity1 = $this->createEntityMock(1, true, []);66+$entity2 = $this->createEntityMock(2, true, []);67+68+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);69+70+$this->queryBuilder71+ ->expects($this->once())72+ ->method('getEntityQuery')73+ ->with($updateTarget, $entityIds)74+ ->willReturn($queryBuilder);75+76+$result = $this->action->loadDocuments($updateTarget, $entityIds);77+78+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());79+$this->assertEquals(2, $result->getDocumentsToDelete()->count());80+81+$documentsToDelete = $result->getDocumentsToDelete()->toArray();82+$this->assertEquals(1, $documentsToDelete[0]);83+$this->assertEquals(2, $documentsToDelete[1]);84+ }85+86+public function testLoadDocumentsWithMixedEntities(): void87+ {88+$entityIds = [1, 2, 3, 4];89+$updateTarget = UpdateTarget::ACTIVITY;90+91+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);92+$entity2 = $this->createEntityMock(2, true, []);93+$entity3 = $this->createEntityMock(3, false, ['field3' => 'value3']);94+$entity4 = $this->createEntityMock(4, true, []);95+96+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2, $entity3, $entity4]);97+98+$this->queryBuilder99+ ->expects($this->once())100+ ->method('getEntityQuery')101+ ->with($updateTarget, $entityIds)102+ ->willReturn($queryBuilder);103+104+$result = $this->action->loadDocuments($updateTarget, $entityIds);105+106+$this->assertEquals(2, $result->getDocumentsToUpdate()->count());107+$this->assertEquals(2, $result->getDocumentsToDelete()->count());108+109+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();110+$this->assertEquals('1', $documentsToUpdate[0]->getId());111+$this->assertEquals('3', $documentsToUpdate[1]->getId());112+113+$documentsToDelete = $result->getDocumentsToDelete()->toArray();114+$this->assertEquals(2, $documentsToDelete[0]);115+$this->assertEquals(4, $documentsToDelete[1]);116+ }117+118+public function testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes(): void119+ {120+$entityIds = [1, 2];121+$updateTarget = UpdateTarget::ACTIVITY;122+123+$entity1 = $this->createEntityMock(1, false, ['field1' => 'value1']);124+$entity2 = $this->createEntityMockWithException(2, false);125+126+$queryBuilder = $this->createQueryBuilderMock([$entity1, $entity2]);127+128+$this->queryBuilder129+ ->expects($this->once())130+ ->method('getEntityQuery')131+ ->with($updateTarget, $entityIds)132+ ->willReturn($queryBuilder);133+134+$sentryMock = $this->createMock(SentryMock::class);135+$sentryMock->expects($this->once())136+ ->method('captureException')137+ ->with($this->isInstanceOf(SyncActivityException::class));138+139+ Sentry::swap($sentryMock);140+141+142+$result = $this->action->loadDocuments($updateTarget, $entityIds);143+144+$this->assertEquals(1, $result->getDocumentsToUpdate()->count());145+$this->assertEquals(0, $result->getDocumentsToDelete()->count());146+147+$documentsToUpdate = $result->getDocumentsToUpdate()->toArray();148+$this->assertEquals('1', $documentsToUpdate[0]->getId());149+ }150+151+public function testLoadDocumentsWithEmptyEntityList(): void152+ {153+$entityIds = [];154+$updateTarget = UpdateTarget::ACTIVITY;155+156+$queryBuilder = $this->createQueryBuilderMock([]);157+158+$this->queryBuilder159+ ->expects($this->once())160+ ->method('getEntityQuery')161+ ->with($updateTarget, $entityIds)162+ ->willReturn($queryBuilder);163+164+$result = $this->action->loadDocuments($updateTarget, $entityIds);165+166+$this->assertEquals(0, $result->getDocumentsToUpdate()->count());167+$this->assertEquals(0, $result->getDocumentsToDelete()->count());168+ }169+170+private function createEntityMock(int $id, bool $isDeleted, array $indexableAttributes): Searchable171+ {172+return new class ($id, $isDeleted, $indexableAttributes) implements Searchable {173+public function __construct(174+private int $id,175+private bool $isDeleted,176+private array $indexableAttributes177+ ) {178+ }179+180+public function getId(): int181+ {182+return $this->id;183+ }184+185+public function getIndex(): string186+ {187+return 'test_index';188+ }189+190+public function getSearchKey(): int191+ {192+return $this->id;193+ }194+195+public function getIndexableAttributes(): array196+ {197+return $this->indexableAttributes;198+ }199+200+public function isDeleted(): bool201+ {202+return $this->isDeleted;203+ }204+205+public function setRelations(array $relations): void206+ {207+ }208+ };209+ }210+211+private function createEntityMockWithException(int $id, bool $isDeleted): Searchable212+ {213+return new class ($id, $isDeleted) implements Searchable {214+public function __construct(215+private int $id,216+private bool $isDeleted217+ ) {218+ }219+220+public function getId(): int221+ {222+return $this->id;223+ }224+225+public function getIndex(): string226+ {227+return 'test_index';228+ }229+230+public function getSearchKey(): int231+ {232+return $this->id;233+ }234+235+public function getIndexableAttributes(): array236+ {237+throw new \RuntimeException('Failed to build indexable attributes');238+ }239+240+public function isDeleted(): bool241+ {242+return $this->isDeleted;243+ }244+245+public function setRelations(array $relations): void246+ {247+ }248+ };249+ }250+251+private function createQueryBuilderMock(array $entities): Builder&MockObject252+ {253+$queryBuilder = $this->createMock(Builder::class);254+$queryBuilder->method('cursor')->willReturn(new \ArrayIterator($entities));255+256+return $queryBuilder;257+ }258+}259+260+class SentryMock261+{262+public function captureException(Exception $e)263+ {264+// Do nothing.265+ }266+}</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
This selection contains unit tests for the
LoadDocumentsAction
class, specifically focusing on the
loadDocuments
method. The tests verify how the system hydrates search engine document models from database entities, handling updates, deletions, and exceptions.
Core Functionality Tested
Core Functionality Tested
The tests use a mocked
EntityQueryBuilder
and anonymous
Searchable
classes to simulate different hydration scenarios:
Document Updates:
Verifies that active entities are correctly transformed into
Document
objects containing the expected ID and data (indexable attributes).
Document Deletions:
Ensures that entities flagged as
isDeleted
are processed for removal from the search index.
Mixed Results:
Validates the ability to process a collection containing both updateable and deletable entities in a single stream.
Empty Result Sets:
Confirms the system handles empty entity lists gracefully without errors.
Error Handling & Resilience
Error Handling & Resilience
Exception Catching:
A specific test case (
testLoadDocumentsHandlesExceptionWhenBuildingIndexableAttributes
) ensures that if a single entity fails to hydrate due to an exception, the system:
Logs the error to
Sentry
using a
SyncActivityException
.
Continues processing other valid entities in the stream rather than failing the entire batch.
Technical Implementation Details
Technical Implementation Details
Mocking Strategy:
Uses
createMock
for dependencies and a custom
createEntityMock
helper to generate anonymous classes implementing the
Searchable
interface.
Assertions:
Utilizes PHPUnit assertions like
assertEquals
,
assertInstanceOf
, and
count
to verify the state of the returned result object.
Iterator Usage:
The
createQueryBuilderMock
uses an
ArrayIterator
to simulate a database cursor, reflecting the streaming nature of the hydration process.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.Highlight key changes: Break down the structural or logical changes made in the code.Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Role: You are a Technical Lead. Your task is to provide a clear, high-level summary of the provided code diff or PR selection.
Instructions:
Summarize the core objective: Explain what the code is doing and why (if apparent from the context) using precise and concise language.
Highlight key changes: Break down the structural or logical changes made in the code.
Formatting: Use headers and bulleted lists to make the summary highly scannable for a developer. Avoid long paragraphs.
Accuracy: Maintain the exact meaning and factual accuracy of the provided code without hallucinating outside context.
Open upload file menu
Tools
Open mode picker
Pro
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Jy 20820 es reindex stream model hydration #12059 Edit title
Jy 20820 es reindex stream model hydration
#
12059
Edit title
Preview
Preview
Awaiting approval
Awaiting approval
Code
Code
Open
Vasil-Jiminny
Vasil-Jiminny
wants to merge 35 commits into
master
master
from
JY-20820-es-reindex-stream-model-hydration
JY-20820-es-reindex-stream-model-hydration
Copy head branch name to clipboard
Lines changed: 363 additions & 140 deletions
Conversation (8)
Conversation
(
8
)
Commits (35)
Commits
(
35
)
Checks (3)
Checks
(
3
)
Files changed (12)
Files changed
(
12
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 12 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Component
ElasticSearch/Contract
Searchable.php
Searchable.php
ES
Processor
Actions
LoadDocumentsAction.php
Traits
SkipActivityTrait.php
EntityQueryBuilder.php
EntityQueryBuilder.php
Repositories
EsResetActivityRepository.php
EsResetActivityRepository.php
ElasticSearchDocumentPartialUpdater.php
ElasticSearchDocumentPartialUpdater.php
Console/Commands/Elasticsearch
AsyncUpdateEsActivities.php
AsyncUpdateEsActivities.php
AsyncUpdateEsEntities.php
AsyncUpdateEsEntities.php
Models/ElasticSearch
OpportunityElasticSearchTrait.php
OpportunityElasticSearchTrait.php
tests/Unit/Component/ES/Processor
Actions
LoadDocumentsActionTest.php
LoadDocumentsActionTest.php
Traits
SkipActivityTraitTest.php
SkipActivityTraitTest.php
EntityQueryBuilderTest.php
EntityQueryBuilderTest.php
Collapse file
app/Component/ElasticSearch/Contract/Searchable.php
app/Component/ElasticSearch/Contract/Searchable.php...
|
Firefox
|
Jy 20820 es reindex stream model hydration by Vasi Jy 20820 es reindex stream model hydration by Vasil-Jiminny · Pull Request #12059 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12059/changes
|
9272
|